Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exp push: Handle rev arg as list. #9472

Merged
merged 1 commit into from
May 18, 2023
Merged

exp push: Handle rev arg as list. #9472

merged 1 commit into from
May 18, 2023

Conversation

daavoo
Copy link
Contributor

@daavoo daavoo commented May 17, 2023

Closes #9471

@daavoo daavoo linked an issue May 17, 2023 that may be closed by this pull request
@daavoo daavoo requested a review from dberenbaum May 17, 2023 20:17
@daavoo daavoo self-assigned this May 17, 2023
@daavoo daavoo added A: experiments Related to dvc exp bugfix fixes bug labels May 17, 2023
@daavoo daavoo force-pushed the 9471-exp-push-rev-broken branch from 1450179 to b4be53f Compare May 17, 2023 20:23
@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.04 🎉

Comparison is base (e6e3912) 91.56% compared to head (b4be53f) 91.60%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9472      +/-   ##
==========================================
+ Coverage   91.56%   91.60%   +0.04%     
==========================================
  Files         489      489              
  Lines       38231    38264      +33     
  Branches     3475     5489    +2014     
==========================================
+ Hits        35005    35053      +48     
+ Misses       2648     2642       -6     
+ Partials      578      569       -9     
Impacted Files Coverage Δ
dvc/repo/experiments/push.py 81.55% <100.00%> (+0.36%) ⬆️
tests/func/experiments/test_remote.py 100.00% <100.00%> (ø)

... and 28 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@daavoo daavoo merged commit ecb71c8 into main May 18, 2023
@daavoo daavoo deleted the 9471-exp-push-rev-broken branch May 18, 2023 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: experiments Related to dvc exp bugfix fixes bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

exp push --rev broken
1 participant