config: don't look for .dvc dir implicitly #9274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently if dvc_dir doesn't exists (e.g. we are creating an uninitialized repo), config will try looking for `.dvc` dir in the current directory, which might be inside of another dvc repository resulting in mixed configs. Use explicit `from_cwd` method to make `Config` try to find repo configs if available to avoid the usage mixup.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #9274 +/- ##
=======================================
Coverage 92.85% 92.86%
=======================================
Files 459 459
Lines 37144 37149 +5
Branches 5356 5357 +1
=======================================
+ Hits 34490 34498 +8
+ Misses 2122 2120 -2
+ Partials 532 531 -1
... and 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if dvc_dir doesn't exists (e.g. we are creating an uninitialized repo), config will try looking for
.dvcdir in the current directory, which might be inside of another dvc repository resulting in mixed configs.Use explicit
from_cwdmethod to makeConfigtry to find repo configs if available to avoid the usage mixup.Related #8789
Related #9246