-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add top-level artifacts:
section
#9220
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #9220 +/- ##
==========================================
- Coverage 92.94% 92.93% -0.01%
==========================================
Files 459 461 +2
Lines 37112 37202 +90
Branches 5342 5357 +15
==========================================
+ Hits 34493 34575 +82
- Misses 2089 2093 +4
- Partials 530 534 +4
... and 3 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
from dvc.repo import Repo | ||
|
||
|
||
class ArtifactsFile(FileMixin): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd have preferred not to use FileMixin
, it's too bloated. But I am fine for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me so far.
@aguschin Let's update it to handle paths like top-level plots (use |
Ok, ready for another review if needed :) |
Thanks @aguschin! Could you also add monorepo tests per iterative/gto#198 (comment)? |
Only if they are currently untracked and `--temp` or `--queue` is passed. Closes iterative#7842
This PR adds a top-level declarative section that is going to be used instead of GTO's
artifacts.yaml
Example: