8998 exp run include new staged files #9017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daavoo
commented
Feb 13, 2023
daavoo
force-pushed
the
8998-exp-run-include-new-staged-files
branch
2 times, most recently
from
62b411d to
ac9fd80
Compare
Codecov ReportBase: 93.02% // Head: 93.08% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #9017 +/- ##
==========================================
+ Coverage 93.02% 93.08% +0.06%
==========================================
Files 455 456 +1
Lines 36760 36799 +39
Branches 5318 5328 +10
==========================================
+ Hits 34195 34256 +61
+ Misses 2040 2020 -20
+ Partials 525 523 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
daavoo
commented
Feb 14, 2023
| @pytest.mark.parametrize("staged", [True, False]) | ||
| def test_deleted(tmp_dir, scm, dvc, caplog, tmp, staged): | ||
| if not tmp: | ||
| pytest.xfail("TODO: https://github.com/iterative/dvc/issues/6297") |
There was a problem hiding this comment.
Deleted files are still not handled properly for workspace in local init_git. Will fix in follow-up as the current P.R. already fixes #8998
pmrowla
approved these changes
Feb 14, 2023
daavoo
force-pushed
the
8998-exp-run-include-new-staged-files
branch
from
ac9fd80 to
cac9192
Compare
- Detach head after stashing workspace. - Use reinstate_index.
daavoo
force-pushed
the
8998-exp-run-include-new-staged-files
branch
from
cac9192 to
366e322
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8998