Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import-url: fix update after cloud versioned import-url --no-download #8984

Merged
merged 3 commits into from
Feb 8, 2023

Conversation

pmrowla
Copy link
Contributor

@pmrowla pmrowla commented Feb 8, 2023

Thank you for the contribution - we'll try to review it as soon as possible. 🙏

Fixes #8954
Should also resolve the "files are downloaded after dvc update with no changes" problem in #8464

@pmrowla pmrowla added A: data-sync Related to dvc get/fetch/import/pull/push A: cloud-versioning Related to cloud-versioned remotes labels Feb 8, 2023
@pmrowla pmrowla self-assigned this Feb 8, 2023
@codecov
Copy link

codecov bot commented Feb 8, 2023

Codecov Report

Base: 93.12% // Head: 93.09% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (042adec) compared to base (b4db1e0).
Patch coverage: 25.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8984      +/-   ##
==========================================
- Coverage   93.12%   93.09%   -0.03%     
==========================================
  Files         455      455              
  Lines       36678    36689      +11     
  Branches     5299     5300       +1     
==========================================
+ Hits        34155    34157       +2     
- Misses       2007     2015       +8     
- Partials      516      517       +1     
Impacted Files Coverage Δ
dvc/output.py 88.77% <0.00%> (-0.26%) ⬇️
dvc/testing/workspace_tests.py 64.04% <12.50%> (-2.43%) ⬇️
dvc/repo/imports.py 88.33% <100.00%> (+0.19%) ⬆️
dvc/repo/index.py 91.44% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pmrowla pmrowla merged commit 93c556a into iterative:main Feb 8, 2023
@pmrowla pmrowla deleted the 8954-versioned-import-no-dl branch February 8, 2023 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: cloud-versioning Related to cloud-versioned remotes A: data-sync Related to dvc get/fetch/import/pull/push
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cloud versioning issue: dvc pull doesn’t work after dvc import-url …. --no-download
1 participant