fix exception on dvc stage add with non-existing dirs #8645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
running `dvc stage add <..> -o nonexisting_dir/file` would fail with a `FileNotFoundError` for the `.gitignore` file in `nonexisting_dir`. This happened because the outputs are added to the `.gitignore` when creating the stage.
Codecov ReportBase: 94.13% // Head: 94.13% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #8645 +/- ##
=======================================
Coverage 94.13% 94.13%
=======================================
Files 435 435
Lines 33335 33335
Branches 4690 4690
=======================================
Hits 31379 31379
Misses 1528 1528
Partials 428 428 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
😄 See iterative/example-repos-dev#153. Happy to close mine for this. I went with ignoring the failure instead of creating the dirs, but I'm fine with either. |
|
I like your approach best, closing this in favour of #8644 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running
dvc stage add <..> -o nonexisting_dir/filewould fail with aFileNotFoundErrorfor the.gitignorefile innonexisting_dir. This happened because the outputs are added to the.gitignorewhen creating the stage.To reproduce:
mkdir tmp cd tmp git init dvc init dvc stage add -f -n prepare \ -p prepare.seed,prepare.split \ -d src/prepare.py -d data/data.xml \ -o data/prepared --pdb \ python src/prepare.py data/data.xmlthis will raise
FileNotFoundError: data/.gitignorefixes #5802