Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

worktree push: do not push existing versions #8606

Merged
merged 2 commits into from
Nov 23, 2022

Conversation

pmrowla
Copy link
Contributor

@pmrowla pmrowla commented Nov 22, 2022

Thank you for the contribution - we'll try to review it as soon as possible. πŸ™

Closes #8354

  • For files that already have version ID information from a previous push, if that version still exists on the remote we will not push a new version of that file (regardless of whether or not the "latest" version on the remote matches the one we want to push)
  • Adds progress bars and fixes reported upload/download file count on worktree push/fetch

@pmrowla pmrowla added A: data-sync Related to dvc get/fetch/import/pull/push A: cloud-versioning Related to cloud-versioned remotes labels Nov 22, 2022
@pmrowla pmrowla self-assigned this Nov 22, 2022
@codecov
Copy link

codecov bot commented Nov 22, 2022

Codecov Report

Base: 94.22% // Head: 94.22% // No change to project coverage πŸ‘

Coverage data is based on head (c69d318) compared to base (c69d318).
Patch has no changes to coverable lines.

❗ Current head c69d318 differs from pull request most recent head 106b86a. Consider uploading reports for the commit 106b86a to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8606   +/-   ##
=======================================
  Coverage   94.22%   94.22%           
=======================================
  Files         432      432           
  Lines       33056    33056           
  Branches     4631     4631           
=======================================
  Hits        31146    31146           
  Misses       1484     1484           
  Partials      426      426           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

β˜” View full report at Codecov.
πŸ“’ Do you have feedback about the report comment? Let us know in this issue.

@pmrowla pmrowla merged commit af255a4 into iterative:main Nov 23, 2022
@pmrowla pmrowla deleted the worktree-merge-conflicts branch November 23, 2022 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: cloud-versioning Related to cloud-versioned remotes A: data-sync Related to dvc get/fetch/import/pull/push
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cloud versioning: merge conflicts when collaborating or branching
1 participant