Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

worktree: support push: false #8581

Merged
merged 2 commits into from
Nov 19, 2022
Merged

Conversation

pmrowla
Copy link
Contributor

@pmrowla pmrowla commented Nov 18, 2022

Thank you for the contribution - we'll try to review it as soon as possible. πŸ™

Follow up to #8578.
Related to #8464.

  • Moves worktree push/fetch logic into dvc.repo.worktree
  • Disables pushing dvc import data to worktree remotes
  • Disables pushing push: false data to worktree remotes

@pmrowla pmrowla added A: data-sync Related to dvc get/fetch/import/pull/push A: cloud-versioning Related to cloud-versioned remotes labels Nov 18, 2022
@pmrowla pmrowla self-assigned this Nov 18, 2022
@pmrowla
Copy link
Contributor Author

pmrowla commented Nov 18, 2022

This does not address any of the other worktree push/fetch issues (i.e. reporting that all files are always fetched or pushed/lack of progress bars)

@pmrowla pmrowla requested a review from dberenbaum November 18, 2022 08:25
@codecov
Copy link

codecov bot commented Nov 18, 2022

Codecov Report

Base: 94.31% // Head: 94.27% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (e2d7841) compared to base (a33bbc9).
Patch coverage: 12.28% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8581      +/-   ##
==========================================
- Coverage   94.31%   94.27%   -0.04%     
==========================================
  Files         430      431       +1     
  Lines       32904    32919      +15     
  Branches     4603     4605       +2     
==========================================
+ Hits        31035    31036       +1     
- Misses       1447     1461      +14     
  Partials      422      422              
Impacted Files Coverage Ξ”
dvc/repo/index.py 95.08% <ΓΈ> (ΓΈ)
dvc/repo/worktree.py 7.54% <7.54%> (ΓΈ)
dvc/repo/push.py 58.82% <50.00%> (+28.05%) ⬆️
dvc/repo/fetch.py 77.96% <100.00%> (+8.26%) ⬆️
tests/unit/repo/experiments/conftest.py 88.67% <0.00%> (-5.67%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

β˜” View full report at Codecov.
πŸ“’ Do you have feedback about the report comment? Let us know in this issue.

@dberenbaum
Copy link
Collaborator

Added a checkbox to #8464 for reporting correctly what's been pushed.

@jorgeorpinel
Copy link
Contributor

jorgeorpinel commented Dec 3, 2022

Hi. From #8578 (comment):

Besides updating the cmd refs, should we recommend this by default when building pipelines?

Context: https://discord.com/channels/485586884165107732/1047778499999576084/1048151267190509600

Cc @dberenbaum WDYT

@jorgeorpinel
Copy link
Contributor

I guess the basics of this are also being documented in iterative/dvc.org#4142...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: cloud-versioning Related to cloud-versioned remotes A: data-sync Related to dvc get/fetch/import/pull/push
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants