Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fetch/pull: fix regression when using targeted fetch in repo containing import-url imports #8551

Merged
merged 1 commit into from
Nov 13, 2022

Conversation

pmrowla
Copy link
Contributor

@pmrowla pmrowla commented Nov 13, 2022

Thank you for the contribution - we'll try to review it as soon as possible. πŸ™

Fixes regression introduced in #8528 (discord context https://discord.com/channels/485586884165107732/485596304961962003/1041260802067415070)

@pmrowla pmrowla added regression Ohh, we broke something :-( A: data-sync Related to dvc get/fetch/import/pull/push labels Nov 13, 2022
@pmrowla pmrowla self-assigned this Nov 13, 2022
@codecov
Copy link

codecov bot commented Nov 13, 2022

Codecov Report

Base: 94.31% // Head: 94.31% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (e6ed463) compared to base (014a38f).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8551      +/-   ##
==========================================
- Coverage   94.31%   94.31%   -0.01%     
==========================================
  Files         430      430              
  Lines       32830    32830              
  Branches     4581     4581              
==========================================
- Hits        30963    30962       -1     
- Misses       1449     1450       +1     
  Partials      418      418              
Impacted Files Coverage Ξ”
dvc/output.py 90.06% <0.00%> (-0.17%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

β˜” View full report at Codecov.
πŸ“’ Do you have feedback about the report comment? Let us know in this issue.

@pmrowla pmrowla marked this pull request as ready for review November 13, 2022 08:59
@pmrowla pmrowla enabled auto-merge (rebase) November 13, 2022 09:00
@pmrowla pmrowla added the bugfix fixes bug label Nov 13, 2022
@pmrowla pmrowla changed the title output: fix get_entry dep object generation for imports fetch/pull: fix regression when using targeted fetch in repo containing import-url imports Nov 13, 2022
@efiop efiop disabled auto-merge November 13, 2022 12:41
@efiop efiop merged commit a753ee2 into iterative:main Nov 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: data-sync Related to dvc get/fetch/import/pull/push bugfix fixes bug regression Ohh, we broke something :-(
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants