[WIP] update: add --all flag #8288
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtrifiro
force-pushed
the
update-all-flag
branch
from
c4a40cb
to
2eeef14
Compare
dtrifiro
force-pushed
the
update-all-flag
branch
from
2eeef14
to
748335e
Compare
pmrowla
reviewed
Sep 15, 2022
| if not with_deps: | ||
| return stages | ||
| if stage_filter is not None: | ||
| return list(filter(stage_filter, res)) |
There was a problem hiding this comment.
Why return an instantiated list here instead of just using the filtered generator?
There was a problem hiding this comment.
The stages can be filtered in update itself, no need to complicate collect() further. It will still load them into memory.
|
I don't really feel like this is required since we already have -R, see discussion at #8274 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update --allis an alternative to providing a target or list of targets: when using--all,updateis run against all imports and if required, data is downloaded and.dvcfiles updated.