Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error message when specifying file as target for remove #8044

Merged
merged 2 commits into from
Aug 28, 2022

Conversation

alexmojaki
Copy link
Contributor

@alexmojaki alexmojaki commented Jul 23, 2022

Fixes specifically #5288 (comment)

@alexmojaki alexmojaki requested a review from a team as a code owner July 23, 2022 18:54
@alexmojaki alexmojaki requested a review from efiop July 23, 2022 18:54
@alexmojaki alexmojaki changed the title Remove file message Better error message when specifying file as target for remove Jul 23, 2022
@alexmojaki alexmojaki force-pushed the remove-file-message branch from 04cc636 to 00d43eb Compare July 29, 2022 10:08
dvc/repo/remove.py Outdated Show resolved Hide resolved
@efiop efiop added the awaiting response we are waiting for your reply, please respond! :) label Aug 7, 2022
@daavoo daavoo added the ui user interface / interaction label Aug 9, 2022
@alexmojaki alexmojaki force-pushed the remove-file-message branch from 00d43eb to 661ff01 Compare August 13, 2022 19:12
@alexmojaki
Copy link
Contributor Author

The test failure is an unrelated celery timeout.

@daavoo daavoo enabled auto-merge (squash) August 18, 2022 10:25
@daavoo daavoo force-pushed the remove-file-message branch from af2717b to ef57221 Compare August 18, 2022 10:26
@daavoo daavoo force-pushed the remove-file-message branch from ef57221 to a9feb15 Compare August 25, 2022 11:04
Copy link
Contributor

@efiop efiop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@efiop efiop disabled auto-merge August 28, 2022 22:43
@efiop efiop merged commit 126a646 into iterative:main Aug 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting response we are waiting for your reply, please respond! :) ui user interface / interaction
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants