plots: account for wdir in stage plots #8004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 11, 2022
Closed
efiop
reviewed
Jul 12, 2022
Comment on lines
+346
to
+347
| # TODO dvcfs.path.normopath normalizes to windows path on Windows | ||
| # even though other methods work as expected |
There was a problem hiding this comment.
I see that this comment was in the code before. dvcfs is now posix-based always, so this should no longer be the case.
There was a problem hiding this comment.
It is since the #7477 - the problem still exists: https://github.com/iterative/dvc/runs/7298502413?check_suite_focus=true
pared
force-pushed
the
8003_fix_wdir_plots
branch
from
dce1887 to
9342039
Compare
daavoo
approved these changes
Jul 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #8003
❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏