Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repofs: only use dvcfs when --dvc-only is specified #7659

Merged
merged 1 commit into from
Apr 29, 2022

Conversation

skshetry
Copy link
Member

@skshetry skshetry commented Apr 29, 2022

Thank you for the contribution - we'll try to review it as soon as possible. πŸ™

Closes #5712.

@skshetry skshetry self-assigned this Apr 29, 2022
@skshetry skshetry requested a review from efiop April 29, 2022 06:45
@skshetry skshetry added the optimize Optimizes DVC label Apr 29, 2022
@skshetry skshetry marked this pull request as ready for review April 29, 2022 06:45
@skshetry skshetry requested a review from a team as a code owner April 29, 2022 06:45
Copy link
Contributor

@efiop efiop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've discussed before that we should use dvcfs+subrepos as a new fs here, but indeed with the recent repofs refactor introducing dvc_only is easy and not as ugly as before πŸ˜„

@efiop efiop merged commit b71ea34 into iterative:main Apr 29, 2022
@skshetry skshetry deleted the ls-dvc-only branch April 29, 2022 09:09
@karajan1001
Copy link
Contributor

I think I can continue #6120 for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
optimize Optimizes DVC
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

ls: optimize --dvc-only
3 participants