-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
exp init: change ui prompts structure and output #7497
Conversation
text = ui.rich_text.assemble( | ||
"Created ", | ||
(self.args.name, "bright_blue"), | ||
def _post_init_display( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of the outputs have been moved out of dvc.experiments.init
now (except what we need for prompts) to commands
.
Nice! It works really well, and I think the simplified output text is better. We can probably even drop the line with the link at the end. I'm not sure we need so much styling specific to this command. I think we can even further simplify and make it more consistent. What do you think of this (from https://github.com/dberenbaum/dvc/tree/exp-init-ui)? Light background: |
That makes sense, I went a bit over the top. I want to keep the last message as "You can now run your experiment" as |
@dberenbaum, I’m merging this. I will iterate on top if there’s anything need to change. |
Looks good @skshetry! I think we can call this done for now. |
❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
Closes #7130 and closes #6446.
Screenshots