Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exp init: create params file by default #7413

Merged
merged 1 commit into from
Mar 21, 2022

Conversation

skshetry
Copy link
Member

Note that this won't add support for tracking the params file,
it'll only create the params file. Some changes on error and
prompts are made.

Thank you for the contribution - we'll try to review it as soon as possible. 🙏

@skshetry skshetry requested a review from a team as a code owner February 22, 2022 13:02
@skshetry skshetry self-assigned this Feb 22, 2022
@skshetry skshetry force-pushed the create-params-exp-init branch from 0f2061c to 646fceb Compare February 22, 2022 13:03
@skshetry skshetry added A: cli Related to the CLI A: experiments Related to dvc exp enhancement Enhances DVC ui user interface / interaction labels Feb 22, 2022
@dberenbaum
Copy link
Collaborator

Note that this won't add support for tracking the params file,
it'll only create the params file.

So the purpose is to allow dvc exp init from an empty repo without failing?

Is it possible to get to #4112 before this? To actually use params, you would have to edit params.yaml and dvc.yaml, right? IMO that's more confusing than failing.

Note: If this PR does move forward, it creates params.yaml regardless of the value of --params.

Copy link
Collaborator

@dberenbaum dberenbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 Looks great @skshetry!

@skshetry skshetry force-pushed the create-params-exp-init branch from c5d7d4f to 6c23e6b Compare March 16, 2022 13:21
@skshetry skshetry mentioned this pull request Mar 16, 2022
2 tasks
@skshetry skshetry marked this pull request as draft March 17, 2022 07:44
@skshetry skshetry force-pushed the create-params-exp-init branch from 6c23e6b to 9f3345e Compare March 21, 2022 08:05
@skshetry skshetry marked this pull request as ready for review March 21, 2022 08:05
Note that this won't add support for tracking the params file,
it'll only create the params file. Some changes on error and
prompts are made.
@skshetry skshetry force-pushed the create-params-exp-init branch from 9f3345e to e686855 Compare March 21, 2022 09:06
@skshetry skshetry merged commit 9d96ddf into iterative:main Mar 21, 2022
@skshetry skshetry deleted the create-params-exp-init branch March 21, 2022 09:15
@skshetry skshetry restored the create-params-exp-init branch April 27, 2022 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: cli Related to the CLI A: experiments Related to dvc exp enhancement Enhances DVC ui user interface / interaction
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants