Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding remote Argument #7342

Conversation

PietrassykFP
Copy link

This PR fixes issues: #7341

@PietrassykFP PietrassykFP requested a review from a team as a code owner February 3, 2022 13:22
@PietrassykFP PietrassykFP requested a review from dtrifiro February 3, 2022 13:22
@dtrifiro
Copy link
Contributor

dtrifiro commented Feb 3, 2022

Hi @PietrassykFP thanks a lot for the PR!

Would you be interested in taking a shot at adding a test for this PR?

@PietrassykFP
Copy link
Author

@dtrifiro I have absolutely no experience in testing your framework and writing this test would take me ages. But I would really love to have this problem solved. Because dvc is awesome, but we cant use it due to this bug.

@dtrifiro
Copy link
Contributor

dtrifiro commented Feb 4, 2022

No, worries, we'll have a look at it!

@efiop
Copy link
Contributor

efiop commented Feb 8, 2022

Hey @PietrassykFP The issue should be fixed by #7353 , could you please give upstream dvc a try?

@efiop efiop added the awaiting response we are waiting for your reply, please respond! :) label Feb 8, 2022
@efiop
Copy link
Contributor

efiop commented Feb 8, 2022

Thanks to @skshetry for pointing out that we still have a related issue in #7363 🙏 Looking into it.

Closing this one for now, since this particular implementation of the fix is no longer relevant.

@efiop efiop closed this Feb 8, 2022
@PietrassykFP
Copy link
Author

@efiop unfoutunately #7353 did not fix it nor did the most recent development version. The issue is still the same.

@efiop
Copy link
Contributor

efiop commented Feb 10, 2022

@PietrassykFP Thanks for the feedback! We'll be looking further into it in #7363

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting response we are waiting for your reply, please respond! :)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants