push: fix http storage ignoring method setting #6981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add method overriding the default put_file in http.py where the upload method is passed to the http implementation. Fixes: iterative#6694
skshetry
reviewed
Nov 14, 2021
skshetry
reviewed
Nov 14, 2021
Co-authored-by: Saugat Pachhai <[email protected]>
skshetry
approved these changes
Nov 15, 2021
pared
approved these changes
Nov 15, 2021
|
Shouldn't we test that? Not sure how complicated that would be, so we might want to make a separate task out of it. |
21 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add method overriding the default put_file in http.py
where the upload method is passed to the http implementation.
Fixes: #6694
❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏