Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

output: save: remove redundant changed() call #6887

Merged
merged 1 commit into from
Oct 28, 2021
Merged

output: save: remove redundant changed() call #6887

merged 1 commit into from
Oct 28, 2021

Conversation

efiop
Copy link
Contributor

@efiop efiop commented Oct 28, 2021 •
edited
Loading

No longer needed since object introduction, as we will compare staged
object during commit/checkout anyway.

Shaves off ~1s on large dataset in dvc-benchs test_add.

@efiop
output: save: remove redundant changed() call
6a9beb6 
No longer needed since object introduction, as we will compare staged
object during commit/checkout anyway.
@efiop efiop requested a review from a team as a code owner October 28, 2021 22:18
@efiop efiop requested a review from pared October 28, 2021 22:18
@efiop efiop added the performance improvement over resource / time consuming tasks label Oct 28, 2021
@efiop efiop merged commit 869ea44 into iterative:master Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pared pared Awaiting requested review from pared pared was automatically assigned from iterative/dvc

Assignees
No one assigned
Labels
performance improvement over resource / time consuming tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@efiop