Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dvcfs: handle new workspace subdirectories in walk #6811

Merged
merged 1 commit into from
Oct 19, 2021

Conversation

eggqq007
Copy link
Contributor

@eggqq007 eggqq007 commented Oct 15, 2021

  1. add try-catch to catch KeyError exception while walking dvc folder
  2. Fix list .: fails on added directory path (tracked dataset) #6695

Thank you for the contribution - we'll try to review it as soon as possible. 🙏

@eggqq007 eggqq007 requested a review from a team as a code owner October 15, 2021 08:29
@eggqq007 eggqq007 requested a review from karajan1001 October 15, 2021 08:29
dvc/fs/dvc.py Outdated Show resolved Hide resolved
@pmrowla
Copy link
Contributor

pmrowla commented Oct 15, 2021

This should get a new test case for the original error

@eggqq007
Copy link
Contributor Author

This should get a new test case for the original error

Sure,will update later

@efiop efiop added the awaiting response we are waiting for your reply, please respond! :) label Oct 18, 2021
1. add try-catch to catch KeyError exception while walking dvc folder
2. Fix iterative#6695
Copy link
Contributor

@karajan1001 karajan1001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pmrowla pmrowla changed the title catch KeyError exception while walking dvc folder dvcfs: handle new workspace subdirectories in walk Oct 19, 2021
@pmrowla pmrowla added bugfix fixes bug and removed awaiting response we are waiting for your reply, please respond! :) labels Oct 19, 2021
@pmrowla pmrowla merged commit 6d96ecb into iterative:master Oct 19, 2021
@eggqq007 eggqq007 deleted the fix-dvc-list branch October 19, 2021 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix fixes bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

list .: fails on added directory path (tracked dataset)
4 participants