-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up remotes's exps #6471
Clean up remotes's exps #6471
Conversation
fix iterative#6006 1. add a new argument `--git-remote` to `dvc exp remove` 2. add some tests for it
@dberenbaum @pmrowla |
Yes, I think granular removal is needed here. My preferred usage would be to make
|
Thinking about it, I'm a bit confused about the command semantics. Maybe the argument these last accept should be the git remote (perhaps made optional if the branch has a default upstream), resembling |
The mandatory argument for
Git branch upstream/tracking remotes are specifically only for git branch refs, they don't apply to any other git ref (including experiments). The reason we require explicit git remote arguments is because the "correct" git behavior for "default remotes" will end up being confusing for users. |
1. support remote a special remote exp 2. modify the tests for it 3. fix an issue in dvc exp pull
1. fix iterative#6421. 2. add a test for it. 3. do some refactors
Co-authored-by: Jorge Orpinel <[email protected]>
for more information, see https://pre-commit.ci
Co-authored-by: Jorge Orpinel <[email protected]>
``` import file mismatch: imported module 'test_utils' has this __file__ attribute: /home/runner/work/dvc/dvc/tests/unit/repo/experiments/test_utils.py which is not the same as the test file we want to collect: /home/runner/work/dvc/dvc/tests/unit/stage/test_utils.py HINT: remove __pycache__ / .pyc files and/or use a unique basename for your test file modules ```
If
|
Looks good, thanks for being patient with all the review requests π |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor issue with the arg parsing. Otherwise looks great!
Co-authored-by: Dave Berenbaum <[email protected]>
* Remove exps in remote git repo. related to iterative/dvc#6471 * Add an example to it * Update content/docs/command-reference/exp/remove.md Co-authored-by: Jorge Orpinel <[email protected]> * Update doc according to core PR * ref: exp remove -g updates * Some format problems * Update content/docs/command-reference/exp/remove.md Co-authored-by: Jorge Orpinel <[email protected]>
fix #6006
--git-remote
todvc exp remove
β I have followed the Contributing to DVC checklist.
π If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
Remove exps in remote git repo.Β dvc.org#2744
Thank you for the contribution - we'll try to review it as soon as possible. π