add support for Python 3.10 #6422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyarrow is not available, so we are skipping tests for it. And, restricting `hdfs` extras to be not installed in Python3.10. Pathlib removed `_init` method and `init` parameter, so just working around that. It's not a big change.
pywin32 is not yet available for 3.10 Python, so skipping those for now
* 'python310' of github.com:skshetry/dvc: Unpin networkx Remove a special queued experiments (iterative#6393) build(deps): bump google-cloud-storage from 1.41.1 to 1.42.0 (iterative#6415) Push running checkpoint to remote (iterative#6332)
skshetry
commented
Aug 13, 2021
| - name: install libgit2 on Python3.10 in macOS | ||
| if: matrix.pyv == '3.10.0-rc.1' && matrix.os == 'macos-10.15' | ||
| run: | | ||
| brew install libgit2 |
There was a problem hiding this comment.
Python3.10 only running in macOS as libgit2-1.1 is not available in Ubuntu (only >= 21.04 which is not supported in GHA).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pyarrowis not available, so we are skipping tests for it.And, restricting
hdfsextras to be not installed in Python3.10.Pathlib removed
_initmethod andinitparameter, so just workingaround that. It's not a big change, even compared to 3.9.
pygit2andpyarrowdoes not have wheels,pywin32is not available for Windows at this point (which is a critical dependency in the Windows for us).If you can install
libgit2-1.1and are on macOS/Linux, there should not be any issues on 3.10.Ubuntu < 21.04 does not provide libgit2-1.1 which pygit2 requires.
In the CI, to be sure it works well with Python3.10, we run
macOSwith libgit2 installed frombrew.Not adding a trove classifier for Python3.10 support, as we should:
pyarrow/pywin32/pygit2.When adding proper support, I should remember to check following in the future.:
hdfsfixtures.pywin32for Windows + Python >= 3.10.pyarrowfor Python >= 3.10.dulwich/ruamel.yaml.Closes #6164.
❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏