ssh: handle concurrency issues for raw command execution #6370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efiop
approved these changes
Jul 29, 2021
|
Tested in my setup, works like charm now. Thank you! 🙏 |
|
Thanks for giving it a try @efiop! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #6295 (comment). There are 2 primary issues, one is that we used to max out all the sessions with SFTP channels, so after a certain amount of operations there wasn't any channels to use for SSH. Now we allocate 2 channels for it. The second issue is that,
AsyncFileSystemthat fsspec offers overrides themove()command with it's owncopy()+remove()implementation. Now that is also temporarily fixed on the sshfs, and will submit a patch against fsspec upstream.