objects: fix gdrive CI issue #6338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efiop
reviewed
Jul 20, 2021
dvc/fs/base.py
Outdated
Comment on lines
185
to
188
| size = self.info(path_info).get("size") | ||
| if size is not None: | ||
| size = int(size) | ||
| return size |
There was a problem hiding this comment.
Was gdrive returning string size? fs.info should always return size as int, so prob worth fixing in gdrive.py itself.
There was a problem hiding this comment.
Yeah, there were 2 issues
- after the transfer change we were verifying the destination ODB on both push and pull, when previously we only verified on pull
- the verify on push caused us to read sizes from the gdrive fs, which made the issue w/gdrive returning string sizes show up
I'll move the conversion into our gdrive fs, still waiting for the branch build to finish to make sure there's nothing else
pmrowla
force-pushed
the
odb-transfer-gdrive
branch
from
0db5b1d to
a36750a
Compare
efiop
approved these changes
Jul 20, 2021
efiop
added
bugfix
|
Thank you, @pmrowla ! 🙏 |
|
Hm, looks like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏