Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fsspec: create directories on upload/upload_fobj #6309

Merged
merged 1 commit into from
Jul 14, 2021
Merged

Conversation

isidentical
Copy link
Contributor

@isidentical isidentical commented Jul 13, 2021

Since we start adding non-object systems (e.g webdav, ssh) there is now a requirement for makedirs() calls before upload/upload_fobj/copy operations. Also the _with_bucket, and _strip_bucket functions are closely tied with the object filesytems so they are moved under the ObjectFsWrapper.

@isidentical isidentical requested a review from a team as a code owner July 13, 2021 11:06
@isidentical isidentical requested a review from karajan1001 July 13, 2021 11:06
@isidentical isidentical force-pushed the fsspec-create-dirs branch 2 times, most recently from 82fd88a to 30858dc Compare July 13, 2021 12:39
@isidentical isidentical self-assigned this Jul 13, 2021
@efiop efiop merged commit 6275f5d into master Jul 14, 2021
@efiop efiop deleted the fsspec-create-dirs branch July 14, 2021 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants