add: ignore duplicated targets? #6286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skshetry
changed the title
|
What about a warning? It's not clear to me whether this would ever be intended behavior, or whether it would be important for someone to know they had added the same target twice. |
|
@dberenbaum, it could happen with typos when similar targets exist. The main reason for this PR is that our internals cannot handle this properly (especially the graph checks), so we have to handle it at the top. I'll add a warning then. |
skshetry
force-pushed
the
duplicate-targets
branch
2 times, most recently
from
144dfeb to
f4001e5
Compare
skshetry
commented
Jul 7, 2021
| dupes = counter.most_common(n=2) | ||
| if dupes: | ||
| msg = ", ".join(f"[b]{key}[/]" for key, _ in dupes) | ||
| ui.error_write(f"ignoring duplicated targets: {msg}", styled=True) |
There was a problem hiding this comment.
hmm, the capitalization of message (or, not) could be another topic for the UI discussion.
skshetry
force-pushed
the
duplicate-targets
branch
from
f4001e5 to
63245d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏