params: read from ParamsDependency if possible #5550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pared
commented
Mar 5, 2021
Comment on lines
-197
to
-79
| def test_diff_deleted_config(tmp_dir, scm, dvc): | ||
| tmp_dir.gen("params.yaml", "foo: bar") | ||
| dvc.run(cmd="echo params.yaml", params=["foo"], single_stage=True) | ||
| scm.add(["params.yaml", "Dvcfile"]) | ||
| scm.commit("bar") | ||
|
|
||
| (tmp_dir / "params.yaml").unlink() | ||
|
|
||
| assert dvc.params.diff() == { | ||
| "params.yaml": {"foo": {"old": "bar", "new": None}} | ||
| } | ||
|
|
||
|
|
There was a problem hiding this comment.
Copy of previous test (test_diff_deleted).
pared
force-pushed
the
5451_track_used
branch
4 times, most recently
from
217f647 to
c373e3e
Compare
dvc/command/experiments.py
Outdated
Comment on lines
787
to
789
| experiments_show_parser.add_argument( | ||
| "-t", | ||
| "--tracked-params", |
There was a problem hiding this comment.
They're all (usually) "tracked", just some by Git. It's more about which ones are stage dependencies I think? So how about --deps or --only-deps (or --param-deps in this case)
Context: #5451 (comment)
pared
force-pushed
the
5451_track_used
branch
2 times, most recently
from
a04c45b to
aa9f780
Compare
pared
changed the title
There was a problem hiding this comment.
Names LGTM. One copy edit below (repeated 3 times).
I'm a bit surprised about the amount of logic needed to achieve this at first sight. Would it be easier to make this the default behavior and add option/logic to expand the scope? Well... I guess we have an entire discussion about that somewhere so never mind.
|
LGTM |
pmrowla
approved these changes
Mar 31, 2021
Co-authored-by: Jorge Orpinel <[email protected]>
Co-authored-by: Jorge Orpinel <[email protected]>
Co-authored-by: Jorge Orpinel <[email protected]>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
ref: doc
params/exp show/diff --param(-deps)dvc.org#2371Thank you for the contribution - we'll try to review it as soon as possible. 🙏
Fixes #5451
The change adds new flags:
--depsfordvc params diffand--param-depsfordvc exp show/diffin order to show only those parameters that are actually used. It does not change current behaviour.Related:
iterative/enhancement-proposals#1