update: forbid updating repo-imports with --to-remote #5475
Conversation
|
Hi @isidentical I see there's a docs PR for this (https://github.com/iterative/dvc.org/pull/2175/files), thanks! I'm just not sure this was mentioned completely? What was forbidden exactly? It seems like update works perfectly well with --to-remote imports. Maybe I just don't understand this PR. |
| raise InvalidArgumentError( | ||
| "Can't update a repo import with --to-remote" | ||
| ) |
There was a problem hiding this comment.
What's a repo import? Got it.
There was a problem hiding this comment.
BTW I'm not sure that term will mean anything for users. If that exception is a user message I would rephrase to something more explicit like "Data imported with dvc import can't be updated --to-remote." or "Only data imported with dvc import-url --to-remote can be updated --to-remote." — or whatever is most correct.
|
Oh I see "repo import" means a |
I agree that the error message is a bit term-focused, even though it is the correct term. Let's just use |
|
Yes or maybe more general like "Data imported from other DVC or Git repositories can't be updated to-remote." to avoid terminology completely. Although maybe mentioning the exact command is better. Up to you |
|
p.s. is there a core issue to keep track of these ideas? |
nop, though feel free to just create an issue and CC me |
❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here. (will mention in cmd: add dvc update --to-remote docs dvc.org#2175)
Thank you for the contribution - we'll try to review it as soon as possible. 🙏