exp run: remove exp reset in favor of exp run --reset
#5442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dberenbaum
reviewed
Feb 10, 2021
| @@ -98,11 +95,11 @@ def test_experiments_run(dvc, scm, mocker, args, reset): | |||
| "jobs": None, | |||
| "tmp_dir": False, | |||
| "checkpoint_resume": None, | |||
| "reset": reset, | |||
| "reset": False, | |||
There was a problem hiding this comment.
Is a "reset": True case needed?
There was a problem hiding this comment.
The command unit tests are mainly for making sure the CLI parsing works. The actual reset=true/false functionality is tested in tests/func/experiments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏
Related to #5413
dvc exp resetcommand is removeddvc exp run --resetoption can be used to reset/restart checkpoints