dvc: handle multiline command as list #5194
Conversation
Implements an approach proposed by @skshetry. Fixes iterative#4373
| @@ -47,7 +47,7 @@ def warn_if_fish(executable): | |||
|
|
|||
| def _enforce_cmd_list(cmd): | |||
| assert cmd | |||
| return cmd if isinstance(cmd, list) else [cmd] | |||
| return cmd if isinstance(cmd, list) else cmd.splitlines() | |||
There was a problem hiding this comment.
A minor thing: What should we do in the dvc.lock file? Should we keep them in a single format (like either a list or a multiline?)? Just that when the user changes the multiline string to a list or vice versa, it should not affect the lock file.
It might be too much to support that way, but just saying that in principle, it'd be better to have a single format in the lock file, but I think it happens rarely in practice and the list and the multiline string might never be equivalent when user refactors them.
Just addressing your point that we should handle multiline as a list, so we could close that ticket 🙂 |
|
Please note that I closed iterative/dvc.org#2721 as stale but I understand that's not something that has been released (per iterative/dvc.org#2721 (comment)) right? thanks |
Implements an approach proposed by @skshetry.
Fixes #4373
❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
iterative/dvc.org#2071
Thank you for the contribution - we'll try to review it as soon as possible. 🙏