Add mypy config, fix type errors in a few remaining places #4951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skshetry
added
testing
skshetry
commented
Nov 24, 2020
| @@ -42,7 +42,6 @@ def __init__(self, key, new, into): | |||
| ) | |||
| return | |||
|
|
|||
| assert isinstance(new, Node) and isinstance(into[key], Node) | |||
There was a problem hiding this comment.
There was already a "if" clause checking it's negation. :)
skshetry
commented
Nov 24, 2020
| with suppress(FileNotFoundError): | ||
| return self.sftp.lstat(path).st_mode |
There was a problem hiding this comment.
mypy had problem figuring out return type here. Dunno why.
skshetry
commented
Nov 24, 2020
| open_fn = tree.open if tree else open | ||
| with open_fn(path, "w+", encoding="utf-8") as fd: | ||
| with open_fn(path, "w+", encoding="utf-8") as fd: # type: ignore |
There was a problem hiding this comment.
We need to fix PathInfo situation soon, if we need to keep adding more types.
efiop
reviewed
Nov 24, 2020
skshetry
commented
Nov 24, 2020
| @@ -1,34 +1,70 @@ | |||
| """Common utilities for serialize.""" | |||
| import os | |||
| from contextlib import contextmanager | |||
| from typing import TYPE_CHECKING, Any, Callable, ContextManager, Dict, Union | |||
|
|
|||
| from typing_extensions import Protocol | |||
There was a problem hiding this comment.
Need to add this package on conda_forge too.
efiop
approved these changes
Nov 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I haven't added it to the CI yet, as it will only confuse the contributors. We should add it after we have significant type coverage.
To run that locally, just run:
❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏