Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dag: add --outs option #4739

Merged
merged 1 commit into from
Nov 12, 2020
Merged

dag: add --outs option #4739

merged 1 commit into from
Nov 12, 2020

Conversation

gurobokum
Copy link
Contributor

@gurobokum gurobokum commented Oct 18, 2020

Close #4532

Thank you for the contribution - we'll try to review it as soon as possible. πŸ™

for stage in H.nodes:
G.add_nodes_from(stage.outs)

for from_stage, to_stage in nx.edge_dfs(H):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for edge_dfs

Copy link
Contributor

@pmrowla pmrowla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think this probably needs a docs PR to at least update the usage for dvc dag?

@efiop efiop added the awaiting response we are waiting for your reply, please respond! :) label Oct 27, 2020
@gurobokum
Copy link
Contributor Author

Based on review I've removed pylint: disable=W0621 section and provided update on dvc.org iterative/dvc.org#1918
Please take a look πŸ‘€ πŸ™

@pmrowla pmrowla merged commit eeba567 into iterative:master Nov 12, 2020
@pmrowla
Copy link
Contributor

pmrowla commented Nov 12, 2020

Thanks @JIoJIaJIu πŸ™

I159 added a commit to I159/dvc that referenced this pull request Nov 12, 2020
…limit

* 'master' of github.com:iterative/dvc:
  dag: add --outs option (iterative#4739)
  Add test server and tests for webdav (iterative#4827)
  Simpler param updates with python-benedict (iterative#4780)
  checkpoints: set DVC_ROOT environment variable (iterative#4877)
  api: add support for simple wildcards (iterative#4864)
  tests: mark azure test as flaky (iterative#4881)
  setup.py: limit responses version for moto (iterative#4879)
  remote: avoid chunking on webdav. Fixes iterative#4796 (iterative#4828)
  checkpoints: `exp run` and `exp res[ume]` refactor (iterative#4855)
@efiop efiop added feature request Requesting a new feature and removed awaiting response we are waiting for your reply, please respond! :) labels Nov 18, 2020
restyled-io bot pushed a commit to iterative/dvc.org that referenced this pull request Dec 18, 2020
shcheklein pushed a commit to iterative/dvc.org that referenced this pull request Dec 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Requesting a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dvc dag --outs
5 participants