#1618 Custom message when cache and remote are in sync

[tenitski]

Addresses #1618 issue

Update dvc status -r X or dvc status -c commands by printing out a more specific message if cache and remote are in sync with each other.

[tenitski]

There could be a better phrased message, I'm open to suggestions.

[efiop]

Hm, Cache and remote are in sync sounds a bit like cache and remote have the same list of cache files, which is actually not true, because we care about the cache for the local workspace or branches/tags (--all-tags, --all-branches). But this is still a good start 👍

[tenitski]

I used this paragraph from dvc status documentation as a guide for what is happening and how it should be phrased:

For new and deleted data, the cache is different from remote storage. Bringing the two into sync requires dvc pull or dvc push. For the typical process to update the workspace, see Sharing Data And Model Files.

[tenitski]

So if you don't need to do anything to bring them into sync I thought we can call the state as "are in sync" :)

[tenitski]

I'm keen to work out the best message cause this PR is all about making the message more accurate. Having an OK message kind of defeats the purpose...

[efiop]

@tenitski Thanks for the attention to details! 🙏

@jorgeorpinel could you take a look, please?

[jorgeorpinel]

Minor: based on the elif order below wouldn't it be better to put this new constant before UP_TO_DATE_MSG?

As for the text itself, it seems good but mentioning the cache seems too low-level. Maybe "This repo is in sync with the remote." ? Also, may be no need to specify which remote since the user should know that already... But I guess for when you have a default remote, to make sure you're aware of which one was checked, appending the remote name at the end is not a bad idea.

[efiop]

One more thing, in the PR header there was a checkbox for the docs. This PR will require doc change, so could you please at least create an issue for it on https://github.com/iterative/dvc.org/issues ?

[tenitski]

When I created the PR I checked docs page for dvc status but could not see there anything that would become out of date because of this change. Can you point out a specific place please?

[efiop]

@tenitski Oh, good to know 👌 Pretty much https://dvc.org/doc/command-reference/status will need some adjustment in If no differences are detected, dvc status prints paragraph and there might be some now incorrect "Data and pipelines are up to date" messages all across the docs (i.e. will have to grep https://github.com/iterative/dvc.org/tree/master/content for it and adjust messages for -c/-r invocation).

[tenitski]

@tenitski Oh, good to know 👌 Pretty much https://dvc.org/doc/command-reference/status will need some adjustment in If no differences are detected, dvc status prints paragraph and there might be some now incorrect "Data and pipelines are up to date" messages all across the docs (i.e. will have to grep https://github.com/iterative/dvc.org/tree/master/content for it and adjust messages for -c/-r invocation).

Oh, yeah, makes sense. I didn't think about other pages which may refer to this message.