Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/http ssl verify configuration #4547

Merged

Conversation

MetalBlueberry
Copy link
Contributor

I need to disable ssl verification in some cases. This feature allows to put this into dvc configuration.

Thank you!

@MetalBlueberry
Copy link
Contributor Author

I do not understand why is not building on 12853.2 3.7 on Windows. Looks like it was interrupted for some reason.

how should I proceed?

Copy link
Contributor

@efiop efiop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks! 🙏

Could you please add it to HTTP section in https://dvc.org/doc/command-reference/remote/modify too? There is an edit button on the right.

Btw, are you present on our discord? If you are not, check out https://dvc.org/chat , we have a #dev-talk channel there specifically for dev-related things. Also, if you wish, let us know your discord nickname, so we could add you to the contributors group 🙂 Thank you so much for contributing! 🙏

@MetalBlueberry
Copy link
Contributor Author

Documented!

iterative/dvc.org#1767

Copy link
Contributor

@efiop efiop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🙏

@efiop efiop merged commit 54a48e3 into iterative:master Sep 9, 2020
@efiop
Copy link
Contributor

efiop commented Sep 9, 2020

For the record: We will be releasing 1.7.0 later today.

@jorgeorpinel
Copy link
Contributor

I do not understand why is not building on 12853.2 3.7 on Windows. Looks like it was interrupted for some reason.

Hi @MetalBlueberry , is this still happening to you? Does pip install crash for you too (that started happening to me recently)? Can you share the error if so? Thanks

@MetalBlueberry
Copy link
Contributor Author

I do not understand why is not building on 12853.2 3.7 on Windows. Looks like it was interrupted for some reason.

Hi @MetalBlueberry , is this still happening to you? Does pip install crash for you too (that started happening to me recently)? Can you share the error if so? Thanks

Hi @jorgeorpinel , I just saw it in the Github pipeline. I'm a linux user so I cannot guide you in how to fix this error. You can always switch to linux ¯\_(ツ)_/¯

@efiop efiop added the feature is a feature label Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature is a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants