Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dvc: override replace in HTTPURLInfo to include extra_parts #4517

Merged
merged 3 commits into from
Sep 3, 2020
Merged

dvc: override replace in HTTPURLInfo to include extra_parts #4517

merged 3 commits into from
Sep 3, 2020

Conversation

MetalBlueberry
Copy link
Contributor

Fix #4508

@MetalBlueberry
dvc: override replace in HTTPURLInfo to include extra_parts
888c536 
The objective is to passtrough any parameter configured in http remotes.

fixes #4508
@MetalBlueberry MetalBlueberry mentioned this pull request Sep 2, 2020
Closed
@shcheklein
Copy link
Member

@MetalBlueberry thanks! :) 🙏

efiop
efiop reviewed Sep 2, 2020
View reviewed changes
dvc/path_info.py Show resolved Hide resolved
@MetalBlueberry
Copy link
Contributor Author

I have one question, Should we include this change in URLInfo class instead of HTTPURLInfo? From my point of view, a replace method should only replace the given parameter and leave the others with the same value. In this case, the path.

@efiop
Copy link
Contributor

efiop commented Sep 3, 2020

Should we include this change in URLInfo class instead of HTTPURLInfo

remotes that use URLInfo don't actually have fragments/queries/params (at least from what I know), so I would rather not adjust it, unless someone has a use case. With HTTP it is pretty clear that it should be supported there.

efiop
efiop reviewed Sep 3, 2020
View reviewed changes
tests/unit/test_path_info.py Outdated Show resolved Hide resolved
efiop
efiop approved these changes Sep 3, 2020
View reviewed changes
Copy link
Contributor

@efiop efiop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🙏

@efiop efiop merged commit 79e8e4e into iterative:master Sep 3, 2020
@MetalBlueberry MetalBlueberry deleted the fix/http_remote_is_ignored_#4508 branch September 3, 2020 19:57
@skshetry skshetry added the enhancement Enhances DVC label Sep 7, 2020
@jorgeorpinel jorgeorpinel mentioned this pull request Sep 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efiop efiop efiop approved these changes

Assignees
No one assigned
Labels
enhancement Enhances DVC
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

http remote: url query is ignored
4 participants
@MetalBlueberry @shcheklein @efiop @skshetry