Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error message when no match found. #4354

Merged
merged 4 commits into from
Aug 10, 2020
Merged

Conversation

karajan1001
Copy link
Contributor

@karajan1001 karajan1001 commented Aug 7, 2020

Thanks to @skshetry 's suggestions. A quick but might temporarily fix, is there any better solution?

fix #4351

  1. remove error message when no match found.

Thank you for the contribution - we'll try to review it as soon as possible. 🙏

1. remove error message when no match found.
1.Test update cover return 0 and 1
@pared pared self-requested a review August 7, 2020 08:05
@efiop efiop merged commit 07dcf69 into iterative:master Aug 10, 2020
@karajan1001 karajan1001 deleted the fix_4351 branch April 7, 2021 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

check-ignore: confusing help message when no matches are found [qa]
3 participants