Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: use wtree for non-repo configs #4341

Merged
merged 1 commit into from
Aug 6, 2020

Conversation

efiop
Copy link
Contributor

@efiop efiop commented Aug 5, 2020

config: use wtree for non-repo configs

For example, when dvc importing something, dvc won't see stuff
declared in system and global configs, because GitTree doesn't see stuff
that is outside of the git repo.

Discord context:
https://discordapp.com/channels/485586884165107732/563406153334128681/740543492417126521

Thank you for the contribution - we'll try to review it as soon as possible. 🙏

For example, when `dvc import`ing something, dvc won't see stuff
declared in system and global configs, because GitTree doesn't see stuff
that is outside of the git repo.

Discord context:
https://discordapp.com/channels/485586884165107732/563406153334128681/740543492417126521
@efiop efiop force-pushed the fix-config-tree branch from e675a25 to 41169f9 Compare August 6, 2020 11:42
@efiop efiop changed the title [WIP] config: use wtree for non-repo configs config: use wtree for non-repo configs Aug 6, 2020
@efiop efiop requested review from pared, pmrowla and skshetry August 6, 2020 11:45
@efiop efiop merged commit 7afff1e into iterative:master Aug 6, 2020
@efiop efiop self-assigned this Aug 11, 2020
@efiop efiop deleted the fix-config-tree branch August 11, 2020 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants