-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Two new mode -all
and --stdin
for dvc check-ignore
#4322
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abspath Co-authored-by: Ruslan Kuprieiev <[email protected]>
Co-authored-by: Jorge Orpinel <[email protected]>
Co-authored-by: Jorge Orpinel <[email protected]>
This reverts commit 27eec49.
1. Argument `targets`'s description. 2. Error handling of `_get_normalize_path`
Co-authored-by: Ruslan Kuprieiev <[email protected]>
1. Add a new test for the out side repo cases 2. check ignore now only check one file not file lists
Fix iterative#3736 1. Introduce new arguments `--all` for `dvc check-ignore` 2. Add tests for `dvc check-ignore --all` 3. Introduce an interactive mode for `dvc check-ignore` with arguments `--stdin` on
Fix iterative#3736 1. Introduce new arguments `--all` for `dvc check-ignore` 2. Add tests for `dvc check-ignore --all` 3. Introduce an interactive mode for `dvc check-ignore` with arguments `--stdin` on
@karajan1001 Could you please rebase on top of master? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4321
--all
fordvc check-ignore
dvc check-ignore --all
dvc check-ignore
with arguments--stdin
on❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏