dvc: fix --quiet mode #4304
Merged
dvc: fix --quiet mode #4304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efiop
commented
Jul 30, 2020
| @@ -92,11 +101,3 @@ def main(argv=None): | |||
| # Remove cached repos in the end of the call, these are anonymous | |||
| # so won't be reused by any other subsequent run anyway. | |||
| clean_repos() | |||
There was a problem hiding this comment.
Ideally these should be put into atexit kinda like https://github.com/python/cpython/blob/e1945307d36849f8be8937144cf3dd6ebab6274c/Lib/multiprocessing/util.py#L362 . Since they are not only relevant for CLI but for API as well. This also might be the reason why we are getting some weird fini errors in tests.
efiop
commented
Jul 30, 2020
dvc/main.py
Outdated
Comment on lines
40
to
50
| verbosity = args.verbose - args.quiet | ||
| if verbosity: | ||
| logger.setLevel( | ||
| { | ||
| -2: logging.CRITICAL, | ||
| -1: logging.ERROR, | ||
| 1: logging.DEBUG, | ||
| 2: logging.TRACE, | ||
| }[max(-2, min(verbosity, 2))] | ||
| ) | ||
| level = None | ||
| if args.quiet: | ||
| level = logging.CRITICAL | ||
| elif args.verbose: | ||
| trace = args.verbose > 1 | ||
| level = logging.TRACE if trace else logging.DEBUG | ||
|
|
||
| if level is not None: | ||
| logger.setLevel(level) | ||
|
|
There was a problem hiding this comment.
Got a bit too fancy with the magic 🙂
Part of the issue is a bug from iterative#3806 Kudos to @karajan1001 for finding this bug while working on iterative#4282
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the issue is a bug from #3806
Kudos to @karajan1001 for finding this bug while working on #4282
❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏