Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

force YAML 1.1 syntax when dumping yaml files with ruamel #4295

Closed
wants to merge 1 commit into from
Closed

force YAML 1.1 syntax when dumping yaml files with ruamel #4295

wants to merge 1 commit into from

Conversation

dtrifiro
Copy link
Contributor

workaround for #4281

@dtrifiro dtrifiro marked this pull request as draft July 28, 2020 13:31
@dtrifiro dtrifiro force-pushed the fix-lockfile-dumper branch from 38ee3c5 to 1d1dce1 Compare July 30, 2020 11:27
@efiop efiop requested a review from skshetry July 31, 2020 00:36
@weekly-digest weekly-digest bot mentioned this pull request Aug 2, 2020
Closed
skshetry
skshetry reviewed Aug 5, 2020
View reviewed changes
Copy link
Member

@skshetry skshetry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @dtrifiro for taking it so long. PR looks good, that might be enough, but looks like some tests are failing.
Let me see and get back to you on this. And, thanks for the PR and bug report. 👍

@skshetry
Copy link
Member

skshetry commented Aug 6, 2020

Tests are failing because this workaround adds "% YAML 1.1` which is a yaml version directive to the start of the YAML files.

We need to find some way to avoid this (but still dump in 1.1 version).

@skshetry
Copy link
Member

skshetry commented Aug 7, 2020

just did a simple benchmarking for ruamel. It's twice as slow as pyyaml for example-get-started's dvc.yaml load.

@weekly-digest weekly-digest bot mentioned this pull request Aug 9, 2020
Closed
@skshetry skshetry mentioned this pull request Aug 11, 2020
Closed
2 tasks
@skshetry skshetry force-pushed the fix-lockfile-dumper branch from 1d1dce1 to 4cb04bb Compare August 12, 2020 13:16
@skshetry skshetry force-pushed the fix-lockfile-dumper branch from 4cb04bb to afa4510 Compare August 12, 2020 13:20
@dtrifiro
Copy link
Contributor Author

Development moved to #4380

@dtrifiro dtrifiro closed this Aug 14, 2020
@dtrifiro dtrifiro deleted the fix-lockfile-dumper branch January 10, 2022 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skshetry skshetry skshetry left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dtrifiro @skshetry