Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove: remove dvc.yaml and dvc.lock if they are empty #4196

Merged
merged 5 commits into from
Jul 13, 2020
Merged

remove: remove dvc.yaml and dvc.lock if they are empty #4196

merged 5 commits into from
Jul 13, 2020

Conversation

nik123
Copy link
Contributor

@nik123 nik123 commented Jul 12, 2020 •
edited
Loading

Fixes #4090

iterative/dvc.org#1564

@nik123 nik123 mentioned this pull request Jul 12, 2020
Closed
@efiop efiop requested a review from skshetry July 12, 2020 17:15
skshetry
skshetry reviewed Jul 13, 2020
View reviewed changes
Copy link
Member

@skshetry skshetry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nik123 for the PR. It looks good, though I have a few suggestions regarding the implementation.

dvc/dvcfile.py Outdated Show resolved Hide resolved
tests/func/test_dvcfile.py Outdated Show resolved Hide resolved
@nik123 nik123 requested a review from skshetry July 13, 2020 15:28
@jorgeorpinel jorgeorpinel mentioned this pull request Jul 13, 2020
Merged
3 tasks
@efiop efiop merged commit 1c9588e into iterative:master Jul 13, 2020
@weekly-digest weekly-digest bot mentioned this pull request Jul 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skshetry skshetry skshetry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

remove: remove dvc.yaml and dvc.lock if they are empty
3 participants
@nik123 @skshetry @efiop