config: use repo.tree #4190
Merged
config: use repo.tree #4190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efiop
commented
Jul 10, 2020
dvc/scm/tree.py
Outdated
Comment on lines
40
to
42
| def makedirs(self, path, mode=0o777, exist_ok=True): | ||
| pass | ||
|
|
There was a problem hiding this comment.
Really need to consolidate all this mess #4050 .
Also too dangerous to keep these base methods defunct. Need to use abc or at least raise notimplementederror...
efiop
force-pushed
the
fix-4188
branch
5 times, most recently
from
00082d3 to
1f9e684
Compare
efiop
commented
Jul 11, 2020
| @@ -246,6 +248,9 @@ def __init__( | |||
| else: | |||
| self.dvc_dir = os.path.abspath(os.path.realpath(dvc_dir)) | |||
|
|
|||
| self.wtree = WorkingTree(self.dvc_dir) | |||
| self.tree = tree.tree if tree else self.wtree | |||
There was a problem hiding this comment.
Having to tree.tree because of Repo.tree's setter 🙁 Looks like that will need to be revisited as well in #4050 .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4188
❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
❌ I will check DeepSource, CodeClimate, and other sanity checks below. (We consider them recommendatory and don't expect everything to be addressed. Please fix things that actually improve code or fix bugs.)
Thank you for the contribution - we'll try to review it as soon as possible. 🙏