-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dvc: require --external
for external outputs
#3929
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efiop
added a commit
to iterative/dvc.org
that referenced
this pull request
Jun 2, 2020
efiop
changed the title
dvc: forbid local external outputs
[WIP] dvc: forbid local external outputs
Jun 2, 2020
efiop
changed the title
[WIP] dvc: forbid local external outputs
dvc: require Jun 2, 2020
--external
for external outputs
efiop
added a commit
to iterative/dvc.org
that referenced
this pull request
Jun 2, 2020
efiop
force-pushed
the
fix-1545
branch
2 times, most recently
from
June 2, 2020 04:35
bd6a5d7
to
4904f8c
Compare
skshetry
reviewed
Jun 2, 2020
skshetry
reviewed
Jun 2, 2020
skshetry
reviewed
Jun 2, 2020
efiop
force-pushed
the
fix-1545
branch
3 times, most recently
from
June 2, 2020 16:50
9f8105a
to
9e585bd
Compare
skshetry
approved these changes
Jun 2, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one suggestion. Looks good.
efiop
changed the title
dvc: require
[WIP] dvc: require Jun 2, 2020
--external
for external outputs--external
for external outputs
efiop
added a commit
to iterative/dvc.org
that referenced
this pull request
Jun 2, 2020
efiop
changed the title
[WIP] dvc: require
dvc: require Jun 2, 2020
--external
for external outputs--external
for external outputs
efiop
changed the title
dvc: require
[WIP] dvc: require Jun 2, 2020
--external
for external outputs--external
for external outputs
efiop
force-pushed
the
fix-1545
branch
2 times, most recently
from
June 3, 2020 01:05
d71b86b
to
8f5e8be
Compare
efiop
changed the title
[WIP] dvc: require
dvc: require Jun 3, 2020
--external
for external outputs--external
for external outputs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1545
Related to #3920
β I have followed the Contributing to DVC checklist.
π If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here. If the CLI API is changed, I have updated tab completion scripts.
iterative/dvc.org#1387
Thank you for the contribution - we'll try to review it as soon as possible. π