Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dvc: require --external for external outputs #3929

Merged
merged 1 commit into from
Jun 3, 2020
Merged

Conversation

efiop
Copy link
Contributor

@efiop efiop commented Jun 2, 2020

Fixes #1545
Related to #3920

iterative/dvc.org#1387

  • ❌ I will check DeepSource, CodeClimate, and other sanity checks below. (We consider them recommendatory and don't expect everything to be addressed. Please fix things that actually improve code or fix bugs.)

Thank you for the contribution - we'll try to review it as soon as possible. πŸ™

efiop added a commit to iterative/dvc.org that referenced this pull request Jun 2, 2020
@efiop efiop changed the title dvc: forbid local external outputs [WIP] dvc: forbid local external outputs Jun 2, 2020
@efiop efiop changed the title [WIP] dvc: forbid local external outputs dvc: require --external for external outputs Jun 2, 2020
efiop added a commit to iterative/dvc.org that referenced this pull request Jun 2, 2020
@efiop efiop force-pushed the fix-1545 branch 2 times, most recently from bd6a5d7 to 4904f8c Compare June 2, 2020 04:35
@efiop efiop requested a review from skshetry June 2, 2020 05:06
dvc/stage/__init__.py Outdated Show resolved Hide resolved
dvc/stage/__init__.py Outdated Show resolved Hide resolved
dvc/stage/__init__.py Outdated Show resolved Hide resolved
@efiop efiop force-pushed the fix-1545 branch 3 times, most recently from 9f8105a to 9e585bd Compare June 2, 2020 16:50
Copy link
Member

@skshetry skshetry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one suggestion. Looks good.

dvc/command/run.py Outdated Show resolved Hide resolved
@efiop efiop changed the title dvc: require --external for external outputs [WIP] dvc: require --external for external outputs Jun 2, 2020
efiop added a commit to iterative/dvc.org that referenced this pull request Jun 2, 2020
@efiop efiop changed the title [WIP] dvc: require --external for external outputs dvc: require --external for external outputs Jun 2, 2020
@efiop efiop changed the title dvc: require --external for external outputs [WIP] dvc: require --external for external outputs Jun 2, 2020
@efiop efiop force-pushed the fix-1545 branch 2 times, most recently from d71b86b to 8f5e8be Compare June 3, 2020 01:05
@efiop efiop changed the title [WIP] dvc: require --external for external outputs dvc: require --external for external outputs Jun 3, 2020
@efiop efiop merged commit ac4f351 into iterative:master Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add: from external FS or local external outputs
2 participants