-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
external_repo: use RepoTree for fetch/import/get #3841
Conversation
saving tree to cache
* otherwise md5 checksums will not match when comparing git version to cached filesystem version on windows
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great!
For the record: discussed next steps to possibly unify and abstract trees by, possibly, splitting BaseRemote into one Remote + S3Tree(and so on for each type) + Cache.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
β I have followed the Contributing to DVC checklist.
π If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here. If the CLI API is changed, I have updated tab completion scripts.
β I will check DeepSource, CodeClimate, and other sanity checks below. (We consider them recommendatory and don't expect everything to be addressed. Please fix things that actually improve code or fix bugs.)
Thank you for the contribution - we'll try to review it as soon as possible. π
Related to #3811.
Will fix #3611.
Changes:
git checkout
for cloned repos (unless dvcxfor_write=True
)RepoTree
/cache.save()
for fetching external DVC+ git filespull_to
erepo.fetch_external() -> cache.checkout
with host repo cacheerepo.fetch_external() -> cache.checkout()
with erepo tmpdir cachels
: use RepoTree