Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(OutputAlreadyTrackedError): Add git suggestions to stop tracking files #3808

Merged
merged 1 commit into from
May 21, 2020

Conversation

PuneethaPai
Copy link
Contributor

@PuneethaPai PuneethaPai commented May 17, 2020

Fixes: #3678

When file has been already tracked under git, OutputAlreadyTrackedError gets raised.
This commits add git command suggestions to help user to stop tracking file from git,
so in future commits they can use DVC for the file.

  • ❗ I have followed the Contributing to DVC checklist.

  • 📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here. If the CLI API is changed, I have updated tab completion scripts.

  • ❌ I will check DeepSource, CodeClimate, and other sanity checks below. (We consider them recommendatory and don't expect everything to be addressed. Please fix things that actually improve code or fix bugs.)

Thank you for the contribution - we'll try to review it as soon as possible. 🙏

Fixes: iterative#3678
When file has been already tracked under git, OutputAlreadyTrackedError gets raised.
This commits add git command suggestions to help user to stop tracking file from git,
so in future commits they can use DVC for the file.
@efiop efiop requested review from pared, skshetry, pmrowla and jorgeorpinel and removed request for pared May 20, 2020 16:48
Copy link
Contributor

@pared pared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I would keep original issue open (or create new one), as we did not discuss whether we
should include suggestions about https://rtyley.github.io/bfg-repo-cleaner/

@efiop
Copy link
Contributor

efiop commented May 21, 2020

@pared Let's not ecommend bfg for now, as it is too specific. Merging and closing the original issue.

Thanks! @PuneethaPai 🙏

@efiop efiop merged commit 040458a into iterative:master May 21, 2020
efiop added a commit that referenced this pull request May 21, 2020
@shcheklein
Copy link
Member

@PuneethaPai also, it looks there is something funny happening with your Git settings - Github does not attribute commits properly to you (probably some discrepancy in emails - Github and local Git?)

@PuneethaPai
Copy link
Contributor Author

PuneethaPai commented May 22, 2020

Thanks @shcheklein and @efiop . I just realized my local git user.email was configured with different id than the one with github login. Thanks for pointing this out. Will keep in mind in future.
PS: Big fan of this project. 🥰

@efiop
Copy link
Contributor

efiop commented May 23, 2020

@PuneethaPai You can still add it in https://github.com/settings/emails , so github will automatically associate your existing commits with your profile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add/run: improve "already tracked" message
5 participants