-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plot: update some output strings #3759
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3759 +/- ##
==========================================
+ Coverage 90.58% 90.65% +0.06%
==========================================
Files 158 158
Lines 10572 10572
==========================================
+ Hits 9577 9584 +7
+ Misses 995 988 -7
Continue to review full report at Codecov.
|
Only Py36 on Linux build failed (https://travis-ci.com/github/iterative/dvc/builds/164523499). Looks like a glitch? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment, besides that LGTM.
Fixed your comment, @pared. I also made a few more changes to match the now published version in https://dvc.org/doc/command-reference/plot/diff as well as a few more small upcoming changes in iterative/dvc.org/pull/1283. PTAL |
β I have followed the Contributing to DVC checklist.
π If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here. If the CLI API is changed, I have updated tab completion scripts.
β I will check DeepSource, CodeClimate, and other sanity checks below. (We consider them recommendatory and don't expect everything to be addressed. Please fix things that actually improve code or fix bugs.)
Thank you for the contribution - we'll try to review it as soon as possible. π