Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plot: update some output strings #3759

Merged
merged 4 commits into from
May 12, 2020
Merged

plot: update some output strings #3759

merged 4 commits into from
May 12, 2020

Conversation

jorgeorpinel
Copy link
Contributor

@jorgeorpinel jorgeorpinel commented May 7, 2020

  • ❗ I have followed the Contributing to DVC checklist.

  • πŸ“– If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here. If the CLI API is changed, I have updated tab completion scripts.

  • ❌ I will check DeepSource, CodeClimate, and other sanity checks below. (We consider them recommendatory and don't expect everything to be addressed. Please fix things that actually improve code or fix bugs.)

Thank you for the contribution - we'll try to review it as soon as possible. πŸ™

@jorgeorpinel jorgeorpinel requested a review from pared May 7, 2020 15:58
@codecov
Copy link

codecov bot commented May 7, 2020

Codecov Report

Merging #3759 into master will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3759      +/-   ##
==========================================
+ Coverage   90.58%   90.65%   +0.06%     
==========================================
  Files         158      158              
  Lines       10572    10572              
==========================================
+ Hits         9577     9584       +7     
+ Misses        995      988       -7     
Impacted Files Coverage Ξ”
dvc/command/plot.py 77.17% <ΓΈ> (ΓΈ)
dvc/repo/plot/data.py 93.56% <ΓΈ> (ΓΈ)
dvc/system.py 86.88% <0.00%> (-2.46%) ⬇️
dvc/compat.py 72.22% <0.00%> (+55.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update 785dcfe...ab1d34a. Read the comment docs.

@jorgeorpinel jorgeorpinel marked this pull request as ready for review May 7, 2020 16:23
@jorgeorpinel
Copy link
Contributor Author

jorgeorpinel commented May 7, 2020

Only Py36 on Linux build failed (https://travis-ci.com/github/iterative/dvc/builds/164523499). Looks like a glitch?

@jorgeorpinel jorgeorpinel changed the title plot: update datafile desc. plot: update datafile desc. et al. May 7, 2020
@jorgeorpinel jorgeorpinel changed the title plot: update datafile desc. et al. plot: update some output strings May 7, 2020
@jorgeorpinel jorgeorpinel mentioned this pull request May 7, 2020
Copy link
Contributor

@pared pared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, besides that LGTM.

dvc/command/plot.py Outdated Show resolved Hide resolved
@jorgeorpinel
Copy link
Contributor Author

jorgeorpinel commented May 12, 2020

Fixed your comment, @pared. I also made a few more changes to match the now published version in https://dvc.org/doc/command-reference/plot/diff as well as a few more small upcoming changes in iterative/dvc.org/pull/1283. PTAL

@efiop efiop requested a review from pared May 12, 2020 10:54
@efiop efiop merged commit 1e7efff into master May 12, 2020
@delete-merged-branch delete-merged-branch bot deleted the plot-datafile branch May 12, 2020 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants