Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snap version #3741

Merged
merged 2 commits into from
May 5, 2020
Merged

Snap version #3741

merged 2 commits into from
May 5, 2020

Conversation

casperdcl
Copy link
Contributor

  • fix snapcraft on travis CI missing version tags

@casperdcl casperdcl self-assigned this May 4, 2020
@casperdcl
Copy link
Contributor Author

@efiop looks like the snap builds started working again miraculously but probably safest to still merge this PR in case it happens again.

@@ -106,6 +106,7 @@ jobs:
- sudo /snap/bin/lxd.migrate -yes
- sudo /snap/bin/lxd waitready
- sudo /snap/bin/lxd init --auto
- git fetch --tags
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

snap was failing on master and PR builds. Not sure how this is related.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think travis was failing in some cases to pull tags, so git describe was failing, meaning snapcraft couldn't get a version.

@efiop efiop merged commit 795f001 into iterative:master May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants