Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] dvc.yaml: rename stages -> run #3728

Closed
wants to merge 1 commit into from

Conversation

efiop
Copy link
Contributor

@efiop efiop commented May 3, 2020

Run is a more natural terminology for data scientists than stages so
it makes sense to rename it so it is more in-sync with it as well as our
commands (e.g. dvc run).

  • ❗ I have followed the Contributing to DVC checklist.

  • 📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here. If the CLI API is changed, I have updated tab completion scripts.

  • ❌ I will check DeepSource, CodeClimate, and other sanity checks below. (We consider them recommendatory and don't expect everything to be addressed. Please fix things that actually improve code or fix bugs.)

Thank you for the contribution - we'll try to review it as soon as possible. 🙏

@efiop efiop changed the title dvc.yaml: rename stages -> run [WIP] dvc.yaml: rename stages -> run May 3, 2020
@efiop efiop requested a review from dmpetrov May 3, 2020 20:25
@dmpetrov
Copy link
Member

dmpetrov commented May 4, 2020

It is great idea to get rid of "stages", @efiop!
As Ivan said this might be confusion between a stage definition and a stage execution/instance. It might be better to use the term pipeline or stages. Pipeline is the best term I think.

@efiop
Copy link
Contributor Author

efiop commented May 4, 2020

@dmpetrov pipeline or pipelines? 🙂

@efiop efiop force-pushed the rename_stages_to_run branch from edb8066 to 2439d6c Compare May 4, 2020 10:46
@efiop
Copy link
Contributor Author

efiop commented May 4, 2020

Changed the PR to use pipeline, but I no longer like it myself. run made more sense to me. But at the same time I don't have an extremely strong opinion about it, as long as it makes sense to our target audience.

@skshetry
Copy link
Member

skshetry commented May 4, 2020

@efiop, pipeline is not technically correct term to use here. Same with run. I think, stages is better than pipeline(s) or run, unless we have good alternatives.

@efiop
Copy link
Contributor Author

efiop commented May 4, 2020

Ok, agreed not to rename it. stages is the best one.

@efiop efiop closed this May 4, 2020
@efiop efiop deleted the rename_stages_to_run branch May 4, 2020 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants