Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dvc remote default in list validation #3715

Merged
merged 8 commits into from
May 9, 2020
Merged

Conversation

karajan1001
Copy link
Contributor

@karajan1001 karajan1001 commented May 1, 2020

  • ❗ I have followed the Contributing to DVC checklist.

  • πŸ“– If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here. If the CLI API is changed, I have updated tab completion scripts.

  • ❌ I will check DeepSource, CodeClimate, and other sanity checks below. (We consider them recommendatory and don't expect everything to be addressed. Please fix things that actually improve code or fix bugs.)

Thank you for the contribution - we'll try to review it as soon as possible. πŸ™

karajan1001 and others added 3 commits April 29, 2020 22:14
Add validation to restrict default remote repo in list of remote repos.
1. add two tests
2. add one validation
3. modified remote remove to satithe validation change
@karajan1001 karajan1001 changed the title 3470 Dvc remote default in list validation May 1, 2020
tests/func/test_config.py Outdated Show resolved Hide resolved
dvc/config.py Outdated Show resolved Hide resolved
@efiop efiop merged commit 6093a1f into iterative:master May 9, 2020
@efiop
Copy link
Contributor

efiop commented May 9, 2020

Sorry for the delay! Thank you so much @karajan1001 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants