-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dvc: implement multistage dvcfile #3676
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skshetry
changed the title
[WIP] dvc: implementing multistage dvcfile with locks, and without separate output stages
[WIP] dvc: implement multistage dvcfile with locks, and without separate output stages
Apr 24, 2020
skshetry
changed the title
[WIP] dvc: implement multistage dvcfile with locks, and without separate output stages
[WIP] dvc: implement multistage dvcfile
Apr 24, 2020
skshetry
force-pushed
the
multistage-dvcfile
branch
from
April 24, 2020 15:29
f2e0901
to
f8952e2
Compare
skshetry
force-pushed
the
multistage-dvcfile
branch
from
April 27, 2020 13:42
f8952e2
to
dd2c992
Compare
efiop
reviewed
Apr 27, 2020
skshetry
changed the title
[WIP] dvc: implement multistage dvcfile
dvc: implement multistage dvcfile
Apr 28, 2020
efiop
reviewed
Apr 28, 2020
efiop
reviewed
Apr 28, 2020
efiop
reviewed
Apr 28, 2020
efiop
reviewed
Apr 28, 2020
efiop
reviewed
Apr 28, 2020
efiop
reviewed
Apr 28, 2020
efiop
reviewed
Apr 28, 2020
efiop
reviewed
Apr 28, 2020
efiop
reviewed
Apr 28, 2020
efiop
reviewed
Apr 28, 2020
efiop
reviewed
Apr 28, 2020
efiop
reviewed
Apr 28, 2020
efiop
reviewed
Apr 28, 2020
efiop
approved these changes
Apr 28, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Let's merge and iterate over it. π
This was referenced Apr 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
β I have followed the Contributing to DVC checklist.
π If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here. If the CLI API is changed, I have updated tab completion scripts.
document multistage dvcfileΒ dvc.org#1173
β I will check DeepSource, CodeClimate, and other sanity checks below. (We consider them recommendatory and don't expect everything to be addressed. Please fix things that actually improve code or fix bugs.)
Thank you for the contribution - we'll try to review it as soon as possible. π
TODO
pull/push/gc/fetch
collect outs testcheckout
testsremove
testsdestroy
for new lockfiles and pipeline files.ls/get/import
teststatus
testscommit
testslock/unlock
testsrun
testsrepro
testspipelines
testsOn Future Iterations
params
(In a separate PR)lockfile
(will do after it's fixed what the default filename will be, also it already avoids trackingpipelines.lock
file if inside a directory. But,dvc add pipelines.lock
anddvc run -o pipelines.lock
still work.)Part of #1871