Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dvc: implement multistage dvcfile #3676

Merged
merged 14 commits into from
Apr 28, 2020
Merged

Conversation

skshetry
Copy link
Member

@skshetry skshetry commented Apr 24, 2020

Thank you for the contribution - we'll try to review it as soon as possible. πŸ™

TODO

  • pull/push/gc/fetch collect outs test
  • checkout tests
  • remove tests
  • destroy for new lockfiles and pipeline files.
  • ls/get/import test
  • status tests
  • commit tests
  • lock/unlock tests
  • run tests
  • repro tests
  • pipelines tests
  • Check DS and CC

On Future Iterations

  • params (In a separate PR)
  • UX for targets (In a separate PR)
  • Should not allow tracking lockfile (will do after it's fixed what the default filename will be, also it already avoids tracking pipelines.lock file if inside a directory. But, dvc add pipelines.lock and dvc run -o pipelines.lock still work.)

Part of #1871

@skshetry skshetry changed the title [WIP] dvc: implementing multistage dvcfile with locks, and without separate output stages [WIP] dvc: implement multistage dvcfile with locks, and without separate output stages Apr 24, 2020
@skshetry skshetry changed the title [WIP] dvc: implement multistage dvcfile with locks, and without separate output stages [WIP] dvc: implement multistage dvcfile Apr 24, 2020
@skshetry skshetry force-pushed the multistage-dvcfile branch from f2e0901 to f8952e2 Compare April 24, 2020 15:29
@skshetry skshetry force-pushed the multistage-dvcfile branch from f8952e2 to dd2c992 Compare April 27, 2020 13:42
dvc/schema.py Outdated Show resolved Hide resolved
@skshetry skshetry marked this pull request as ready for review April 28, 2020 08:36
@skshetry skshetry requested review from efiop, pared and pmrowla April 28, 2020 08:37
@skshetry skshetry changed the title [WIP] dvc: implement multistage dvcfile dvc: implement multistage dvcfile Apr 28, 2020
dvc/utils/__init__.py Outdated Show resolved Hide resolved
dvc/repo/run.py Outdated Show resolved Hide resolved
dvc/repo/run.py Show resolved Hide resolved
dvc/schema.py Show resolved Hide resolved
dvc/stage/exceptions.py Outdated Show resolved Hide resolved
Copy link
Contributor

@efiop efiop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Let's merge and iterate over it. πŸ‘

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants