Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: extract stage loading outside of dvcfile #3655

Merged
merged 3 commits into from
Apr 20, 2020

Conversation

skshetry
Copy link
Member

  • ❗ I have followed the Contributing to DVC checklist.

  • πŸ“– If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here. If the CLI API is changed, I have updated tab completion scripts.

  • ❌ I will check DeepSource, CodeClimate, and other sanity checks below. (We consider them recommendatory and don't expect everything to be addressed. Please fix things that actually improve code or fix bugs.)

Thank you for the contribution - we'll try to review it as soon as possible. πŸ™

Continuing #1871. Extracts stage load outside of Dvcfile.

@skshetry skshetry added the refactoring Factoring and re-factoring label Apr 20, 2020
@skshetry skshetry self-assigned this Apr 20, 2020
@skshetry skshetry requested review from efiop, pared and pmrowla and removed request for efiop April 20, 2020 14:45
Copy link
Contributor

@efiop efiop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@efiop efiop merged commit 63c466d into iterative:master Apr 20, 2020
@skshetry skshetry deleted the stage-loader branch April 20, 2020 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Factoring and re-factoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants